mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.
Date Tue, 07 Jul 2015 23:31:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/#review90813
-----------------------------------------------------------

Ship it!


Thanks Paul! This is great!

It's a little hard to review this change because you change the file name (I won't be able
to see the diff). It would be better if you change the file name in a separate patch. Next
time!


docs/home.md (line 24)
<https://reviews.apache.org/r/36281/#comment143953>

    I would suggest calling it 'Network Monitoring and Isolation'.
    
    Do not forget to change the file name as well.



docs/network-isolation.md (line 5)
<https://reviews.apache.org/r/36281/#comment143954>

    Ditto. Calling Network Monitoring and Isolation is more appropriate.
    
    Please to a sweep to fix all occurances in this doc.



docs/network-isolation.md (line 7)
<https://reviews.apache.org/r/36281/#comment143956>

    Please do not delete the version information. Network monitoring is added in mesos 0.20
and network isolation is added in mesos 0.23.
    
    I suggest the following layout for the summary paragraph:
    
    ```
    # Network Monitoring and Isolation.
    
    Mesos 0.20.0 adds the support for per container network monitoring. ...
    
    Mesos 0.23.0 adds the support for per container network isolation. ...
    
    Our solution is transparent to the tasks running on the slave ...
    ```



docs/network-isolation.md (line 98)
<https://reviews.apache.org/r/36281/#comment143973>

    Container Network Statistics?


- Jie Yu


On July 7, 2015, 9:54 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36281/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document per-container unique egress flows and network queueing statistics.
> 
> 
> Diffs
> -----
> 
>   docs/home.md bc277910907c381c08835b6e9d485b27d6da5002 
>   docs/network-isolation.md PRE-CREATION 
>   docs/network-monitoring.md 8889fb165cc70bc382be0c99de8d7748328abf57 
> 
> Diff: https://reviews.apache.org/r/36281/diff/
> 
> 
> Testing
> -------
> 
> Rendered at https://www.notehub.org/2015/7/7/network-isolation for review.
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message