mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <bwplo...@gmail.com>
Subject Re: Review Request 36204: Pass slave's total resources in ResourceUsage.
Date Tue, 07 Jul 2015 16:50:22 GMT


> On July 6, 2015, 5:50 p.m., Jie Yu wrote:
> > src/slave/slave.cpp, line 4379
> > <https://reviews.apache.org/r/36204/diff/1/?file=1000223#file1000223line4379>
> >
> >     Per my comments above, the logic here needs to be adjusted. We need to apply
checkpointed resource to info.resources() here.
> >     
> >     Please refer to the following code:
> >     https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L3883

Thanks Jie for your feedback! 

I addressed your issue, however I'm just curious if there is any possibility to get an error
(here in *::usage()*) from *applyCheckpointedResources* function? (https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L3883).
IMO here we are quite sure that *checkpointedResources* are proper. If yes, would it make
sense to just put *info.resources()* into *usage->total* in case we cannot apply checkpointed
resources?


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36204/#review90510
-----------------------------------------------------------


On July 7, 2015, 4:20 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36204/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 4:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod
Kone.
> 
> 
> Bugs: MESOS-2933
>     https://issues.apache.org/jira/browse/MESOS-2933
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pass slave's total resources to the ResourceEstimator and QoSController via Slave::usage().
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 
>   src/slave/slave.cpp 008170f4ce7b97eda43b50b48083b32ae65925c0 
> 
> Diff: https://reviews.apache.org/r/36204/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message