mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 35874: Added template parameters and constructors to hashset to match the signature of hashmap
Date Tue, 07 Jul 2015 08:51:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35874/
-----------------------------------------------------------

(Updated July 7, 2015, 1:51 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Michael Park, and Till Toenshoff.


Changes
-------

Clearer summary.


Summary (updated)
-----------------

Added template parameters and constructors to hashset to match the signature of hashmap


Bugs: MESOS-2924
    https://issues.apache.org/jira/browse/MESOS-2924


Repository: mesos


Description
-------

Adds extra template parameters to hashset as well as implicit constructors from
`std::set` and a initializer list constructor.

These changes keep hashset up to date with the changes in hashmap.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 75ed9db54dc9ab502e978f06c55a621cacb56b91

  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3c4b732432c0c155451d34ecd5f985318d118fe5


Diff: https://reviews.apache.org/r/35874/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message