mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 36216: Only run netcat tests when nc is available.
Date Tue, 07 Jul 2015 08:19:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36216/#review90664
-----------------------------------------------------------



src/tests/docker_containerizer_tests.cpp (line 2123)
<https://reviews.apache.org/r/36216/#comment143798>

    Should we comment the NC in the comment above?



src/tests/environment.cpp (line 251)
<https://reviews.apache.org/r/36216/#comment143799>

    s/so no 'nc' tests/so no tests depending on 'nc'



src/tests/port_mapping_tests.cpp (line 432)
<https://reviews.apache.org/r/36216/#comment143800>

    Should we comment about NC? (see above)


- Joerg Schad


On July 6, 2015, 10:58 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36216/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 10:58 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Chi Zhang, Joerg Schad, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2996
>     https://issues.apache.org/jira/browse/MESOS-2996
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> nc is not available on CentOS 7.1 and all the tests using nc will fail.
> Added a new NetcatFilter so we detect nc before running these tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055 
>   src/tests/environment.cpp 3726e5d95b9388f0881184e1b4874e1eb2e7f531 
>   src/tests/port_mapping_tests.cpp ac49cdfdcf6baf00ac2907e193c683c8b6c83ffb 
> 
> Diff: https://reviews.apache.org/r/36216/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message