mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 32982: Added reservation user guide.
Date Tue, 07 Jul 2015 03:46:49 GMT


> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > Looks great! I know this is already committed, but I had a few questions/clarifications.
Maybe you've answered these elsewhere, but I've been out of the loop for a while.

Thanks for answering my questions. I don't think there's anything that really warrants an
edit/update.


> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > docs/reservation.md, lines 109-110
> > <https://reviews.apache.org/r/32982/diff/12/?file=994059#file994059line109>
> >
> >     Shouldn't the master be able to determine the principal that this frameworkId
is currently authenticated as? Why even allow the framework to specify a different principal
if you're just going to Error?
> 
> Michael Park wrote:
>     Hm, that's true. This was another situation where I wanted to keep  `ReservationInfo.principal`
as `required`.

Fair enough, although it seems like you're leaking the internal data representation into the
user-facing API. Shouldn't be necessary.


> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > docs/reservation.md, line 196
> > <https://reviews.apache.org/r/32982/diff/12/?file=994059#file994059line196>
> >
> >     Could also only unreserve a subset, right?
> 
> Michael Park wrote:
>     Yeah, that's true. I didn't really mention that part.

Not terribly important. Anybody familiar with using resource offers should be able to figure
that one out.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89824
-----------------------------------------------------------


On June 27, 2015, 8:33 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
> 
> (Updated June 27, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
>     https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -----
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> -------
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message