mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 36068: MESOS-2966: Fix 'peer()' call for ssl socket.
Date Mon, 06 Jul 2015 16:23:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36068/#review90491
-----------------------------------------------------------


Joris, this is discarded now and can be removed right?

- Benjamin Hindman


On July 1, 2015, 12:33 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36068/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 12:33 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-2966
>     https://issues.apache.org/jira/browse/MESOS-2966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This virtualizes the 'get()' call on Socket for LibeventSSLSocketImpl to deal with the
extra FD case.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp f53d2e1dbb31e135c8951145d379cbbff3044448

>   3rdparty/libprocess/src/libevent_ssl_socket.hpp 4f2cd357bfdb5268d2bae2df5d7138ff14064bf6

>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 2920e0e1a5643118b14911d77fb682e60958b4e6

>   3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22

> 
> Diff: https://reviews.apache.org/r/36068/diff/
> 
> 
> Testing
> -------
> 
> Added a test. Failed before fix is applied. Passes after.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message