mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.
Date Mon, 06 Jul 2015 05:25:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36173/#review90437
-----------------------------------------------------------

Ship it!


Seems like scalar and text are basic types, and then ranges and sets are compound types. Sounds
weird to talk of 4 types that apply to either, and then only name 3 for each.


docs/attributes-resources.md (line 11)
<https://reviews.apache.org/r/36173/#comment143482>

    s/either supported by Attributes or Resources/supported by Attributes and Resources/
    And are sets a 'type' or just a collection of some other type (text)? Same with ranges,
aren't they just a collection of scalars?



docs/attributes-resources.md (lines 25 - 27)
<https://reviews.apache.org/r/36173/#comment143485>

    s/labelString/text/g?



docs/attributes-resources.md (line 31)
<https://reviews.apache.org/r/36173/#comment143483>

    No sets? Or are attributes implicitly sets?



docs/attributes-resources.md (line 39)
<https://reviews.apache.org/r/36173/#comment143484>

    3 types? What about plain text?


- Adam B


On July 3, 2015, 2:30 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36173/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 2:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update attributes doc to reflect current supported attributes types.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md 0ae8b5908fe0b3a3499e6d813afbb328a13bdcde 
> 
> Diff: https://reviews.apache.org/r/36173/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message