mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 32384: Adding perf check to configure
Date Mon, 06 Jul 2015 03:42:31 GMT


> On July 2, 2015, 11:45 a.m., haosdent huang wrote:
> > configure.ac, line 1121
> > <https://reviews.apache.org/r/32384/diff/2/?file=998167#file998167line1121>
> >
> >     Seems other exist checks use AC_CHECK_TOOL, such as
> >     ```
> >         AC_CHECK_TOOL([PROTOCOMPILER_TEST], [protoc], [], [$PROTOBUFPREFIX/bin])
> >     ```

FYI, I dropped this issue since we killed the configure.ac parts of this review.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32384/#review90210
-----------------------------------------------------------


On July 2, 2015, 8:09 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32384/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 8:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Cody Maloney.
> 
> 
> Bugs: MESOS-2166
>     https://issues.apache.org/jira/browse/MESOS-2166
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> PerfEventIsolatorTest.ROOT_CGROUPS_Sample requires 'perf' to be installed
> 
> 
> Diffs
> -----
> 
>   configure.ac 9290958 
>   src/tests/environment.cpp f111a77 
> 
> Diff: https://reviews.apache.org/r/32384/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message