mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 32384: Adding perf check to configure
Date Mon, 06 Jul 2015 03:41:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32384/#review90428
-----------------------------------------------------------

Ship it!


Your check for 'perf' in the configuration is really not super useful as most folks will likely
just ignore it. The PerfFilter, however, will do the trick sufficiently so I'll just clean
up the issues I mentioned and get this committed, thanks!


src/tests/environment.cpp (line 207)
<https://reviews.apache.org/r/32384/#comment143470>

    To be more consistent with the other TestFilter naming, let's do s/PerfTest/Perf/.



src/tests/environment.cpp (line 215)
<https://reviews.apache.org/r/32384/#comment143471>

    Indentation is off here.



src/tests/environment.cpp (lines 223 - 227)
<https://reviews.apache.org/r/32384/#comment143472>

    This is really unnecessary as they won't even get compiled on non-Linux systems!



src/tests/environment.cpp (line 233)
<https://reviews.apache.org/r/32384/#comment143473>

    Let's add a TODO that captures explicitly marking 'perf' related tests using a similar
naming mechanism as the other filters, e.g., ROOT_, CGROUPS_, etc.


- Benjamin Hindman


On July 2, 2015, 8:09 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32384/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 8:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Cody Maloney.
> 
> 
> Bugs: MESOS-2166
>     https://issues.apache.org/jira/browse/MESOS-2166
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> PerfEventIsolatorTest.ROOT_CGROUPS_Sample requires 'perf' to be installed
> 
> 
> Diffs
> -----
> 
>   configure.ac 9290958 
>   src/tests/environment.cpp f111a77 
> 
> Diff: https://reviews.apache.org/r/32384/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message