-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36179/#review90402
-----------------------------------------------------------
I know this is already merged but can't we just get rid of the foreach (const Environment::Variable...)
block since env already contains the contents of commandInfo.environment().variables(). Or
are there scenarios when that is not true?
- Anindya Sinha
On July 4, 2015, noon, haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36179/
> -----------------------------------------------------------
>
> (Updated July 4, 2015, noon)
>
>
> Review request for mesos, Anindya Sinha and Timothy Chen.
>
>
> Bugs: MESOS-2882
> https://issues.apache.org/jira/browse/MESOS-2882
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix duplicate "-e" environment variables option in Docker::run.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f
>
> Diff: https://reviews.apache.org/r/36179/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
|