mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 36128: Change docker version parsing
Date Thu, 02 Jul 2015 18:00:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36128/#review90257
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On July 2, 2015, 8:58 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36128/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 8:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> We currently use `docker version` to get Docker version, in Docker master branch and
soon in Docker 1.8 [1] the output for this command changes. The solution for now will be to
use the unchanged `docker --version` output, in the long term we should consider stop using
the cli and use the API instead. 
> 
> [1] https://github.com/docker/docker/pull/14047
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp cbcb16e 
> 
> Diff: https://reviews.apache.org/r/36128/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message