mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.
Date Thu, 02 Jul 2015 00:28:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/#review90167
-----------------------------------------------------------



src/linux/perf.cpp (lines 471 - 472)
<https://reviews.apache.org/r/36113/#comment143159>

    This is not converting a line, it's converting a vector of tokens. Can you pass in the
actual line and tokenize here?



src/linux/perf.cpp (lines 493 - 497)
<https://reviews.apache.org/r/36113/#comment143161>

    see below, this shouldn't be used by users directly, instead use an extract(line) wrapper
function that determines the perf version and calls the appropriate parser



src/linux/perf.cpp (lines 509 - 512)
<https://reviews.apache.org/r/36113/#comment143160>

    Perf version should be handled transparently to the caller, i.e., the user just calls
extract(line) and gets the right output.


- Ian Downes


On July 1, 2015, 3:44 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36113/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 3:44 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
> 
> 
> Bugs: mesos-2834
>     https://issues.apache.org/jira/browse/mesos-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> perf: refactored parse to allow determining an output parsing function based on the runtime
version.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 
> 
> Diff: https://reviews.apache.org/r/36113/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message