mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.
Date Wed, 01 Jul 2015 22:19:13 GMT


> On June 25, 2015, 4:12 p.m., Marco Massenzio wrote:
> > src/tests/scheduler_tests.cpp, line 830
> > <https://reviews.apache.org/r/35858/diff/1/?file=991725#file991725line830>
> >
> >     This is a great test (in fact, this looks to me like something we could extract
as example of call sequences in some dev guide?) but it is also a big, scary test: is there
any way it can be broken down in smaller chunks?
> >     
> >     I also have the impression that several of the 'sub-segments' are also present
in other tests: could we reuse them across other tests, maybe?
> >     
> >     Finally, while it may all be very obvious to you :) I would suggest to add some
explanation output on some of the failures, so that in future people less-experienced will
be able to more easily analyze failures, should changes induce breakages.

Not sure what sort of comments do you want in failure messages. GTEST already prints out the
expected and actual values with variable names. FWIW, it is consistent with the rest of the
code base.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89369
-----------------------------------------------------------


On July 1, 2015, 5:26 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35858/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 5:26 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco Massenzio.
> 
> 
> Bugs: MESOS-2551
>     https://issues.apache.org/jira/browse/MESOS-2551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
>   src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 
>   src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 
>   src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f 
> 
> Diff: https://reviews.apache.org/r/35858/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message