mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.
Date Wed, 01 Jul 2015 07:05:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35998/#review90018
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 44)
<https://reviews.apache.org/r/35998/#comment142945>

    Did you check how this displays in the rendered version?



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 94)
<https://reviews.apache.org/r/35998/#comment142944>

    One could add with @see a crossreference to SUS, but I feel this will not add too much
additional value.
    Just pointing out doxygen features :-)


- Joerg Schad


On June 29, 2015, 11:43 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35998/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 11:43 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp a4afdad0b5f053186ace4d6a37b41cd02e7d415b

> 
> Diff: https://reviews.apache.org/r/35998/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message