mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 34646: Redirect to the leader master when current master is not a leader.
Date Wed, 01 Jul 2015 02:19:18 GMT


> On June 30, 2015, 6:48 p.m., Vinod Kone wrote:
> > This is an API change! Before embarking on this change, it's prudent to get feedback
from the community on acceptable semantics (e.g., what do popular metric collectors do if
they encounter 302 redirect? do they ignore the value or follow the redirect? if the latter,
it might result in duplicate collection!). Can you send an email to the dev list?
> 
> haosdent huang wrote:
>     Sure.Thank you for your review. @vinodkone
> 
> Adam B wrote:
>     It's important to note that this patch does not redirect on certain master endpoints
like /observe, /health and the metrics endpoints, since those were seen as potentially host-specific.
Other endpoints like /slaves, /state, /stateSummary, /roles, /tasks, and /teardown were assumed
only useful when they hit the leading master. That said, I agree that this is an API change
and we should make sure the community is okay with the redirects on some endpoints and not
others.
> 
> haosdent huang wrote:
>     Oh, got it. How about change the fix version of this issue to 0.24? @adam-mesos
> 
> Adam B wrote:
>     Unnecessary. We'll just leave it untargeted and let it land whenever it lands. No
reason for it to be a blocker for 0.24.

Ok, so I don't contain the target version in email.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review89945
-----------------------------------------------------------


On June 1, 2015, 3:07 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34646/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 3:07 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-1865
>     https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Return empty task list when current master is not a leader.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 
> 
> Diff: https://reviews.apache.org/r/34646/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> when current master is not a leader, it would redirect to the leader master.
> 
> ```
> $ curl -i http://master1:5050/master/tasks.json
> HTTP/1.1 307 Temporary Redirect
> Date: Mon, 01 Jun 2015 06:30:08 GMT
> Location: http://master2:5050//master/tasks.json
> Content-Length: 0
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message