From reviews-return-3654-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 23 14:55:05 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D33C118930 for ; Tue, 23 Jun 2015 14:55:05 +0000 (UTC) Received: (qmail 10681 invoked by uid 500); 23 Jun 2015 14:55:05 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 10656 invoked by uid 500); 23 Jun 2015 14:55:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 10643 invoked by uid 99); 23 Jun 2015 14:55:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2015 14:55:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A9985A9864; Tue, 23 Jun 2015 14:55:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6407320278188904645==" MIME-Version: 1.0 Subject: Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename. From: "Kapil Arya" To: "Cody Maloney" Cc: "mesos" , "Till Toenshoff" Date: Tue, 23 Jun 2015 14:55:04 -0000 Message-ID: <20150623145504.20383.90329@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/34260/ X-Sender: "Kapil Arya" References: <20150623082651.20383.18287@reviews.apache.org> In-Reply-To: <20150623082651.20383.18287@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos-incubating --===============6407320278188904645== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34260/#review88985 ----------------------------------------------------------- Ship it! LGTM minus some minor comments. Feel free to ignore/drop if they are beyond the scope of this RR :). src/logging/logging.cpp (line 229) May be replace basename here with 'Path(argv0).basename()'? src/slave/main.cpp (line 32) Why do we need this header here? There is no other change in the file. src/slave/state.hpp (lines 130 - 131) I think this will fit on one line :-). - Kapil Arya On June 23, 2015, 4:26 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34260/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 4:26 a.m.) > > > Review request for mesos and Cody Maloney. > > > Bugs: MESOS-1303 > https://issues.apache.org/jira/browse/MESOS-1303 > > > Repository: mesos-incubating > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/cli/mesos.cpp bb92b68e2945be0a2952f289fb28ca2a89e4c5d8 > src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f > src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94 > src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326 > src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527 > src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8 > src/examples/persistent_volume_framework.cpp ee2311f500dbcbbd5691638a706f2fd1b8ae910f > src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55 > src/files/files.cpp 3cdd38a3c7122bd5e13c8928279d85ab1373a63e > src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7 > src/launcher/executor.cpp 9a3a1c3f4952e996bfa12d38627034d18ba9a834 > src/linux/cgroups.cpp 6a87ac4019df1c6ec4465adcdfe711812c209ceb > src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9 > src/logging/logging.cpp 6b1457503ea1f5c07bacb8b396b8536a8ad97566 > src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d > src/slave/containerizer/isolators/cgroups/cpushare.cpp 21e4284f4a0815be1c6c647a491bd2a7653384da > src/slave/containerizer/isolators/cgroups/mem.cpp 9d65bf5b64ce72c1ca9a7a50e65a357e098af63e > src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c > src/slave/containerizer/isolators/network/port_mapping.cpp 1eb8173b0618f7461aa29b1df1ccaf1c2be5f8f6 > src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 > src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746 > src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5 > src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec > src/slave/status_update_manager.cpp 35b943b279c018d846567ec70b374bea83578159 > src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8 > src/tests/mesos.cpp 2cd2435eba4f911867e7e09338aa28e65b2d1f14 > src/zookeeper/group.cpp 33c56da4c83ed6cb272a69df36e6ed2f83583068 > > Diff: https://reviews.apache.org/r/34260/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > > --===============6407320278188904645==--