From reviews-return-2601-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 9 19:25:02 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED55118C9E for ; Tue, 9 Jun 2015 19:25:01 +0000 (UTC) Received: (qmail 65215 invoked by uid 500); 9 Jun 2015 19:25:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 65157 invoked by uid 500); 9 Jun 2015 19:25:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64932 invoked by uid 99); 9 Jun 2015 19:25:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 19:25:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 595941DF932; Tue, 9 Jun 2015 19:25:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3985411584108947519==" MIME-Version: 1.0 Subject: Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave. From: "Mesos ReviewBot" To: "Niklas Nielsen" , "Vinod Kone" , "Ben Mahler" Cc: "mesos" , "Jie Yu" , "Mesos ReviewBot" Date: Tue, 09 Jun 2015 19:25:00 -0000 Message-ID: <20150609192500.27735.28758@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/35260/ X-Sender: "Mesos ReviewBot" References: <20150609185445.27736.99355@reviews.apache.org> In-Reply-To: <20150609185445.27736.99355@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============3985411584108947519== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87272 ----------------------------------------------------------- Patch looks great! Reviews applied: [35259, 35260] All tests passed. - Mesos ReviewBot On June 9, 2015, 6:54 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35260/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 6:54 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2818 > https://issues.apache.org/jira/browse/MESOS-2818 > > > Repository: mesos > > > Description > ------- > > Refactored the ResourceMonitor to get statistics from the Slave. > > 1) Modified ResourceUsage to include allocation information (see ticket for reaons). > 2) Simplied the ResourceMonitor by taking a lambda from the slave to get statistics. > 3) Adjusted (and simplified) the MonitorTest accordingly. > > > Diffs > ----- > > include/mesos/mesos.proto 7457ff11f6a55099ccb95beb2f0ccb9a2f7ccd87 > include/mesos/slave/resource_estimator.hpp 7f78fd86760397d5b885a2c00b41081d0b546cdd > src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 > src/slave/monitor.cpp 8f7ff63b4daf0286d4cf912e2f3d2d1b68caab1c > src/slave/resource_estimators/fixed.cpp 3efa18d7e3c6ac62e67f75ea45a832f3f6349036 > src/slave/resource_estimators/noop.hpp 7a44e6deefc9c1985c14d076a427aa5c654aa1bb > src/slave/resource_estimators/noop.cpp 5f135ff37e84c248ede29bbe4a7d1b8319417e20 > src/slave/slave.hpp 4d2c31688b19f101ec851c0d94e7d45aa2f8a76e > src/slave/slave.cpp 98036b2d5f2c765aef4a416c3cbc082df77ab3ac > src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 > src/tests/mesos.cpp dff45b0d3bf9ef53f19575ab3d90a0b223755d6a > src/tests/monitor_tests.cpp 6de8b1f65843fd7b852dfa69627a1c435b482fe0 > > Diff: https://reviews.apache.org/r/35260/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============3985411584108947519==--