> On June 9, 2015, 1:03 a.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, line 181 > > > > > > Also I added const to the 'values', was that not the intent? I wanted to show that we allow the use of aliases to modify values as well. Iterating through a map is a good example of where that is useful. If that was not clear, then I think it requires a comment so others will understand that as well! :-) - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35120/#review87113 ----------------------------------------------------------- On June 5, 2015, 9:34 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35120/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 9:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Also got rid of an unused struct. > > > Diffs > ----- > > docs/mesos-c++-style-guide.md 38dd201a22dd775971fad190378d022c50885969 > > Diff: https://reviews.apache.org/r/35120/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >