From reviews-return-2156-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jun 3 18:16:59 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6781918AE5 for ; Wed, 3 Jun 2015 18:16:59 +0000 (UTC) Received: (qmail 88633 invoked by uid 500); 3 Jun 2015 18:16:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 88609 invoked by uid 500); 3 Jun 2015 18:16:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 88591 invoked by uid 99); 3 Jun 2015 18:16:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2015 18:16:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B1F8D1DF326; Wed, 3 Jun 2015 18:16:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3802162439837873090==" MIME-Version: 1.0 Subject: Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand. From: "Bartek Plotka" To: "Niklas Nielsen" , "Vinod Kone" , "Szymon Konefal" , "Jie Yu" Cc: "Bartek Plotka" , "mesos" Date: Wed, 03 Jun 2015 18:16:58 -0000 Message-ID: <20150603181658.7996.99184@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bartek Plotka" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/34980/ X-Sender: "Bartek Plotka" References: <20150603055838.1498.86178@reviews.apache.org> In-Reply-To: <20150603055838.1498.86178@reviews.apache.org> Reply-To: "Bartek Plotka" X-ReviewRequest-Repository: mesos --===============3802162439837873090== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 3, 2015, 5:58 a.m., Bartek Plotka wrote: > > Any idea why review requests failed to show diff of noop.hpp? > > > > I guess it something with https://reviews.apache.org/r/34962/diff/#file976910, since this patch depends on that. > > Bartek Plotka wrote: > reviewboard* Now it works - seems to be a cache/mirror issue (: - Bartek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86362 ----------------------------------------------------------- On June 3, 2015, 5:56 a.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34980/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 5:56 a.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone. > > > Bugs: MESOS-2773 > https://issues.apache.org/jira/browse/MESOS-2773 > > > Repository: mesos > > > Description > ------- > > Pass callback to the resource estimator to retrieve ResourceUsage from Resource Monitor on demand. > > This is neccessary, since ResourceEstimator needs data (current statistics for each executor) on which it will base its slack predictions. > > > Diffs > ----- > > include/mesos/slave/resource_estimator.hpp e7f5decdabdfc75587d784a08a98c62ffdfc2909 > src/slave/resource_estimators/noop.hpp 2234ed6da17346c74c2e232ff9eae501531515e1 > src/slave/resource_estimators/noop.cpp PRE-CREATION > src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 > src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e > src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b > > Diff: https://reviews.apache.org/r/34980/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > > --===============3802162439837873090==--