From reviews-return-2091-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 2 23:57:42 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B8A6E174A7 for ; Tue, 2 Jun 2015 23:57:42 +0000 (UTC) Received: (qmail 52675 invoked by uid 500); 2 Jun 2015 23:31:02 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 52650 invoked by uid 500); 2 Jun 2015 23:31:02 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 52635 invoked by uid 99); 2 Jun 2015 23:31:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2015 23:31:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 22EAB1DE686; Tue, 2 Jun 2015 23:31:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1985707331915703424==" MIME-Version: 1.0 Subject: Re: Review Request 34962: Moved NoopResourceEstimator to a separate file. From: "Jie Yu" To: "Niklas Nielsen" , "Bartek Plotka" , "Vinod Kone" Cc: "Jie Yu" , "mesos" Date: Tue, 02 Jun 2015 23:31:02 -0000 Message-ID: <20150602233102.1499.91854@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/34962/ X-Sender: "Jie Yu" References: <20150602232408.1498.41105@reviews.apache.org> In-Reply-To: <20150602232408.1498.41105@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============1985707331915703424== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 2, 2015, 11:24 p.m., Niklas Nielsen wrote: > > Should we name the 'resource_estimator' directory 'resource_estimators' like we name the directory isolators? > > > > I am fine with either; just wanted to get a feel for what pattern we want to go with (the containerizer directory is in singular) > > > > Otherwise, LGTM Hum, seems that we use plural more often than singular (src/tests, src/credentials, src/files, etc.) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34962/#review86315 ----------------------------------------------------------- On June 2, 2015, 11:15 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34962/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 11:15 p.m.) > > > Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Moved NoopResourceEstimator to a separate file. > > As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory. > > > Diffs > ----- > > src/Makefile.am 081185bb28fa58c8fe0b1ffa8db6599def56e85b > src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23 > src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40 > src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d > src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077 > src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39 > src/slave/resource_estimator/noop.cpp PRE-CREATION > src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6 > > Diff: https://reviews.apache.org/r/34962/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============1985707331915703424==--