mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.
Date Fri, 05 Jun 2015 09:35:10 GMT
Here is the review. I used std::string instead. Also cleaned up an unused
struct.
https://reviews.apache.org/r/35120

On Fri, Jun 5, 2015 at 9:58 AM, Joris Van Remoortere <
joris.van.remoortere@gmail.com> wrote:

> Hey BenM,
>
> BenH added spaces before the commit, but thanks for also catching it!
> I'll follow up with a small patch to change the POD to something like
> SlaveID.
>
> Can you shepherd that one? :-)
>
> Joris
>
> On Fri, Jun 5, 2015 at 8:03 AM, Ben Mahler <benjamin.mahler@gmail.com>
> wrote:
>
>>    This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/33271/
>>
>> Thanks guys!
>>
>>
>>    docs/mesos-c++-style-guide.md
>> <https://reviews.apache.org/r/33271/diff/9/?file=976428#file976428line180>
(Diff
>> revision 9)
>>
>> 180
>>
>> foreachpair(const int& key, hashset<int>& values, index) {}
>>
>>   181
>>
>> foreachvalue(const hashset<int>& values, index) {}
>>
>>   182
>>
>> foreachkey(const int& key, index) {}
>>
>>   Do we really want to encourage taking a const& of a POD type? In general we
have not been doing this, so it seems pretty inconsistent to put it in this example.
>>
>> Also, looks like we need a space before the openening parenthesis.
>>
>>
>> - Ben Mahler
>>
>> On June 2nd, 2015, 9:34 a.m. UTC, Joris Van Remoortere wrote:
>>   Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad,
>> Michael Park, and Till Toenshoff.
>> By Joris Van Remoortere.
>>
>> *Updated June 2, 2015, 9:34 a.m.*
>>  *Bugs: * MESOS-2629 <https://issues.apache.org/jira/browse/MESOS-2629>
>>  *Repository: * mesos
>> Description
>>
>> Follow up from r32630.
>>
>>   Diffs
>>
>>    - docs/mesos-c++-style-guide.md
>>    (13312f6f4fe1788791479bd768f60df0a8e80e69)
>>
>> View Diff <https://reviews.apache.org/r/33271/diff/>
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message