mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 36040: Change Server closing connections for every request
Date Tue, 30 Jun 2015 16:24:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36040/#review89909
-----------------------------------------------------------



3rdparty/libprocess/src/http.cpp (line 777)
<https://reviews.apache.org/r/36040/#comment142786>

    What is this change intending to solve ? If it's the ability to not close the connection
for streamed responses.
    
    We would only like to not close the connection i.e. communicate to the client that it's
a persistent connection only when using the streaming API's. 
    
    So the condition should be :
    
    if ( streamedResponse ) {
      ... // don't send the close header
    }
    
    In all other cases, we don't want to use the same connection again, and it's fine to send
the "close" header like we are doing. 
    
    Can you also add @bmahler as a reviewer to confirm this ?


- Anand Mazumdar


On June 30, 2015, 9:06 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36040/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 9:06 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Marco Massenzio, and Vinod Kone.
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Adding the possibility to 'keep-alive' the connection
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http.cpp 0898335 
> 
> Diff: https://reviews.apache.org/r/36040/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message