mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 36018: Remove http specific protocol from master redirect.
Date Tue, 30 Jun 2015 14:07:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36018/#review89894
-----------------------------------------------------------

Ship it!


I added a comment for posterity that explains why it's okay to use protocol-relative URLs
here, thanks!

- Benjamin Hindman


On June 29, 2015, 8:38 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36018/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 8:38 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
> 
> Diff: https://reviews.apache.org/r/36018/diff/
> 
> 
> Testing
> -------
> 
> Still trying to set up an env to test this.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message