mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.
Date Tue, 30 Jun 2015 09:13:30 GMT


> On June 29, 2015, 9:08 p.m., Adam B wrote:
> > Minor points, but otherwise shippable.
> > I guess I'm still a little confused by the motivation. When would the firewall filter
rule have more information about how to respond than the caller would? Can you give an example?
> 
> Alexander Rojas wrote:
>     The idea is to implement SPNEGO in the least intrusive way. That can be achieve with
an `FirewallRule`. The problem happens if the request doesn't include the header `Authenticate:
Negotiate`, in such case, we should return an `HTTP 401 Unauthorize` response with a header
`WWW-Authenticate: Negotiate U29tZSB0ZXh0Cg==`. But this cannot be done if we cannot generate
the response object directly from the `FirewallRule`.

SGTM. Thanks for the explanation.


> On June 29, 2015, 9:08 p.m., Adam B wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 2019-2020
> > <https://reviews.apache.org/r/35919/diff/3/?file=994356#file994356line2019>
> >
> >     You're not logging the Response body anymore?
> 
> Alexander Rojas wrote:
>     Previous reviewer asked to remove it. What should be done in this case?

Fair enough. I'll defer to Till's judgement.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35919/#review89854
-----------------------------------------------------------


On June 30, 2015, 1:34 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35919/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 1:34 a.m.)
> 
> 
> Review request for mesos, Adam B and Till Toenshoff.
> 
> 
> Bugs: MESOS-2877
>     https://issues.apache.org/jira/browse/MESOS-2877
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/firewall.hpp f71d6541e48e2481c69f401b388977b153503962

>   3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e 
> 
> Diff: https://reviews.apache.org/r/35919/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message