mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 36003: MESOS-2942: Documentation for SSL.
Date Tue, 30 Jun 2015 07:37:02 GMT


> On June 29, 2015, 5:57 p.m., Adam B wrote:
> > docs/mesos-ssl.md, lines 58-59
> > <https://reviews.apache.org/r/36003/diff/3/?file=995165#file995165line58>
> >
> >     Can you list RHEL/Ubuntu instructions as well? (For OpenSSL as well)
> 
> Joris Van Remoortere wrote:
>     I'm reluctant to add the instructions as I can't easily verify the version of these
packages on those systems.
>     I wasn't worried about it as much on OSX because those won't be used to run production
servers, and it makes it easier for people to try it out.
>     I'd rather remove the instructions for OSX and suggest building libevent-2.0.22-stable
and the newest stable release of openssl from source.
>     What do you think?

Fair enough. Instead of removing the OSX example, how about just rewording "For OSX" into
"For example, on OSX" so it sounds more like you're giving one install example than that you're
listing detailed install instructions. For other distros, you provided links, and it's left
as an exercise for the sysadmin.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36003/#review89833
-----------------------------------------------------------


On June 29, 2015, 10:47 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36003/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 10:47 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-2942
>     https://issues.apache.org/jira/browse/MESOS-2942
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [Here](https://gist.github.com/jmlvanre/82f30d9ea1ea4d815736) is a Github rendered version
> 
> 
> Diffs
> -----
> 
>   docs/mesos-ssl.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36003/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message