mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 35981: Added persistent volume user guide.
Date Tue, 30 Jun 2015 05:48:38 GMT


> On June 29, 2015, 7:09 p.m., Jie Yu wrote:
> > docs/persistent-volume.md, lines 23-24
> > <https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line23>
> >
> >     We don't store 'principal' in DiskInfo yet. Maybe add a "coming soon" somewhere
as well?

I put it at the end actually. Do you think it would read better if we maybe put it at the
beginning?

> Persistent volumes can be created by __operators__ and authorized
> __frameworks__. We require a `principal` from the operator or
> framework in order to authenticate/authorize the operations.
> [Authorization](authorization.md) is specified via the existing
> ACL mechanism. (___Coming Soon___)

> Persistent volumes can be created by __operators__ and authorized
> __frameworks__. ___Coming Soon___: We require a `principal` from
> the operator or framework in order to authenticate/authorize the
> operations. [Authorization](authorization.md) is specified via
> the existing ACL mechanism.


> On June 29, 2015, 7:09 p.m., Jie Yu wrote:
> > docs/persistent-volume.md, lines 67-69
> > <https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line67>
> >
> >     The numbering is not correct:)

This is actually a markdown feature I learned about:

```
It’s important to note that the actual numbers you use to mark the list have no effect on
the HTML output Markdown produces. The HTML Markdown produces from the above list is:

<ol>
<li>Bird</li>
<li>McHale</li>
<li>Parish</li>
</ol>
If you instead wrote the list in Markdown like this:

1.  Bird
1.  McHale
1.  Parish
or even:

3. Bird
1. McHale
8. Parish
you’d get the exact same HTML output.
```

It allows us to not have to update all of the other numbers if we were to add more items,
remove an item or even rearrange them. It's already used in `docs/release-guide.md` at the
end: `Update external tooling`.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35981/#review89773
-----------------------------------------------------------


On June 28, 2015, 3:35 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35981/
> -----------------------------------------------------------
> 
> (Updated June 28, 2015, 3:35 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2405
>     https://issues.apache.org/jira/browse/MESOS-2405
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md)
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35981/diff/
> 
> 
> Testing
> -------
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message