mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 32982: Added reservation user guide.
Date Tue, 30 Jun 2015 05:37:37 GMT


> On June 28, 2015, 11:36 p.m., Benjamin Hindman wrote:
> > I made a few minor tweaks here before committing.
> > 
> > (1) Replaced the fenced code blocks with indented code blocks so that the doxygen
generated markdown was readable.
> > (2) Made all the 'Coming Soon' be styled consistently (I went with one _, if you'd
prefer the ___ underscore instead we can swap).
> > (3) Made the shell examples be copyable to an actual shell by adding line continuations,
i.e., \.

Thanks for doing that Ben,

(1) Thanks,
(2) Yeah, I left it as _ in the header because the boldness part didn't seem to have any effect
in its rendering. I would probably prefer the ___ since that's what we use in `Getting Started`
as well for (___Recommended___) and, (___Advanced Users Only___)
(3) Sweet!


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89689
-----------------------------------------------------------


On June 28, 2015, 3:33 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
> 
> (Updated June 28, 2015, 3:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
>     https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -----
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> -------
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message