mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 35981: Added persistent volume user guide.
Date Tue, 30 Jun 2015 00:14:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35981/#review89827
-----------------------------------------------------------


Nice work! Just a few cleanups and questions/clarifications.


docs/persistent-volume.md (line 16)
<https://reviews.apache.org/r/35981/#comment142630>

    s/containig/containing/



docs/persistent-volume.md (line 20)
<https://reviews.apache.org/r/35981/#comment142631>

    s/Reservation/the Reservation doc/



docs/persistent-volume.md (line 56)
<https://reviews.apache.org/r/35981/#comment142632>

    Can a volume/reservation created by one framework principal only be destroyed/unreserved
by a framework scheduler using the same principal? If the principal is different, then the
operation would fail, even if the role or even frameworkId is identical?



docs/persistent-volume.md (lines 67 - 69)
<https://reviews.apache.org/r/35981/#comment142633>

    You might need a blank line preceding this, and/or some indentation for it to show up
as a numbered list. Doesn't render properly as is.
    
    Unique per role per slave? So I could use the same volumeId for related volume instances
(e.g. my 'logging' or 'data' volumes), up to a max of one per slave? But if I happen to launch
another executor/task on a slave where one of those volumes is already created/mounted, then
I have to rename it ('data2')?



docs/persistent-volume.md (lines 120 - 122)
<https://reviews.apache.org/r/35981/#comment142635>

    Any chance it could return the host_path too? Or do I have to go digging through slave
logs to figure out where my volume was created?



docs/persistent-volume.md (lines 135 - 136)
<https://reviews.apache.org/r/35981/#comment142637>

    Even after you "destroy" the volume, it still won't be garbage-collected in 0.23. Coming
Soon: https://issues.apache.org/jira/browse/MESOS-2408



docs/persistent-volume.md (line 169)
<https://reviews.apache.org/r/35981/#comment142641>

    There is no `volumes` field. Just a `resources` field, where each resource in the list
must contain a `disk.volume` to be destroyed.


- Adam B


On June 27, 2015, 8:35 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35981/
> -----------------------------------------------------------
> 
> (Updated June 27, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2405
>     https://issues.apache.org/jira/browse/MESOS-2405
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md)
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35981/diff/
> 
> 
> Testing
> -------
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message