mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 32982: Added reservation user guide.
Date Mon, 29 Jun 2015 23:43:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89824
-----------------------------------------------------------


Looks great! I know this is already committed, but I had a few questions/clarifications. Maybe
you've answered these elsewhere, but I've been out of the loop for a while.


docs/reservation.md (line 108)
<https://reviews.apache.org/r/32982/#comment142624>

    I know that we'll want to explicitly specify the role to support future multi-role frameworks,
but why does this need to be included now?



docs/reservation.md (lines 109 - 110)
<https://reviews.apache.org/r/32982/#comment142623>

    Shouldn't the master be able to determine the principal that this frameworkId is currently
authenticated as? Why even allow the framework to specify a different principal if you're
just going to Error?



docs/reservation.md (line 196)
<https://reviews.apache.org/r/32982/#comment142625>

    Could also only unreserve a subset, right?



docs/reservation.md (line 248)
<https://reviews.apache.org/r/32982/#comment142626>

    Again, if we're already authenticating as a certain principal in the request, why do we
need to explicitly specify a (potentially different?) principal in the resources message?



docs/reservation.md (line 309)
<https://reviews.apache.org/r/32982/#comment142627>

    How can there be insufficient resources to unreserve?


- Adam B


On June 27, 2015, 8:33 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
> 
> (Updated June 27, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
>     https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -----
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> -------
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message