mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 36008: Updated upgrades.md about the new 'acceptOffers' API.
Date Mon, 29 Jun 2015 18:18:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36008/#review89758
-----------------------------------------------------------

Ship it!


Looks good to me, although I wouldn't mind a mention of the decline API.


docs/upgrades.md (line 15)
<https://reviews.apache.org/r/36008/#comment142549>

    Might also want to mention how (implicitly) declining full/partial offers plays into this
API. Or is there fuller documentation/doxygen you could reference/link to?


- Adam B


On June 29, 2015, 10:58 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36008/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 10:58 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
> 
> 
> Bugs: MESOS-2481
>     https://issues.apache.org/jira/browse/MESOS-2481
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated upgrades.md about the new 'acceptOffers' API.
> 
> 
> Diffs
> -----
> 
>   docs/upgrades.md 35e893cf7a1ad01d6298c0e7ecfa3bb084807f1c 
> 
> Diff: https://reviews.apache.org/r/36008/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message