mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 35934: New "Not Acceptable" HTTP response type
Date Fri, 26 Jun 2015 22:32:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/#review89582
-----------------------------------------------------------


As a general design note, we should have the `int code` as a separate attribute of the response
(with the associated `statusCode()` getter) - this is what anyone would expect to have.

Can we please add that?

I would also like to see the `string message` to be disaggregated:
```
const int code = 401;
const string message = "Not Authorized";
```
so in the base class you just have:
```
string status() 
{
  return "" + code " " + message;
}
```
which is a much better (composable) design.

- Marco Massenzio


On June 26, 2015, 6:30 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35934/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Needed for HTTP API Call validation patches
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 16f0a01 
> 
> Diff: https://reviews.apache.org/r/35934/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message