mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 35717: Add reservations support to master's state.json
Date Fri, 26 Jun 2015 19:01:51 GMT


> On June 26, 2015, 11:44 a.m., Ben Mahler wrote:
> > I made a minor naming comment, which I'll get cleaned up for you.
> > 
> > Is there a plan to consistently add reserved and unreserved to the other resources?
e.g. used and offered.
> > Curious if you thought about how to express volumes as well?

MPark and I discussed whether we wanted to further break these down, but the primary use case
we considered was operators that want to query what reservations already exist and what resources
are left unreserved, then script a request to update the reservations. We decided to leave
the aggregate for now and break down used/offered/available when a need arises.
We also discussed whether to include unreserved resources as just another `*` role along with
the rest of the role-reservations, but decided that we liked the explicitness of naming it
`unreserved` rather than requiring the user to know about our special `*` role name.

How to express volumes is more related to the stringification of an individual (diskinfo)
resource, rather than the map/list of resources reserved by role. Good question though. We'll
want to make sure these are expressed somehow before the feature goes GA.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89538
-----------------------------------------------------------


On June 22, 2015, 4:37 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 4:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
>     https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message