mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 35836: Replaced slave's 'available' with 'allocated' in hierarchical allocator.
Date Thu, 25 Jun 2015 17:20:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35836/#review89385
-----------------------------------------------------------

Ship it!



src/master/allocator/mesos/hierarchical.hpp (line 233)
<https://reviews.apache.org/r/35836/#comment141965>

    For posterity, can you add a comment here on why we store "allocated" in the allocator
despite having that information in the sorter?


- Vinod Kone


On June 24, 2015, 9:53 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35836/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-2919
>     https://issues.apache.org/jira/browse/MESOS-2919
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced slave's 'available' with 'allocated' in hierarchical allocator.
> 
> This is used to fix MESOS-2919. See ticket for details and motivation.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp ef18ff850addfb5ce3500ed28e8ffd801e2d24eb

> 
> Diff: https://reviews.apache.org/r/35836/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message