mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.
Date Thu, 25 Jun 2015 16:12:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89369
-----------------------------------------------------------

Ship it!


I would like, if possible, to see some documentation added to the new methods (or old ones
too, for that matter) in the form of Doxygen comments: they help greatly in understanding
what classes/methods do.


src/tests/scheduler_tests.cpp (line 830)
<https://reviews.apache.org/r/35858/#comment141944>

    This is a great test (in fact, this looks to me like something we could extract as example
of call sequences in some dev guide?) but it is also a big, scary test: is there any way it
can be broken down in smaller chunks?
    
    I also have the impression that several of the 'sub-segments' are also present in other
tests: could we reuse them across other tests, maybe?
    
    Finally, while it may all be very obvious to you :) I would suggest to add some explanation
output on some of the failures, so that in future people less-experienced will be able to
more easily analyze failures, should changes induce breakages.


- Marco Massenzio


On June 25, 2015, 12:31 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35858/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 12:31 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco Massenzio.
> 
> 
> Bugs: MESOS-2551
>     https://issues.apache.org/jira/browse/MESOS-2551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
>   src/master/master.cpp 0782b543b451921d2240958c7ef612a9e30972df 
>   src/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b 
>   src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f 
> 
> Diff: https://reviews.apache.org/r/35858/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message