mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 34835: Add constexpr to C++ whitelist
Date Thu, 25 Jun 2015 13:01:21 GMT


> On June 18, 2015, 2:46 a.m., Bernd Mathiske wrote:
> > docs/mesos-c++-style-guide.md, line 540
> > <https://reviews.apache.org/r/34835/diff/2/?file=984763#file984763line540>
> >
> >     s/,/. Combining these two sentences deemphasizes the general demand of the first
one.

I don't see this addressed in revision 3. I meant the sentence with a comma in it.


> On June 18, 2015, 2:46 a.m., Bernd Mathiske wrote:
> > docs/mesos-c++-style-guide.md, line 555
> > <https://reviews.apache.org/r/34835/diff/2/?file=984763#file984763line555>
> >
> >     All "," could be "." here.
> >     
> >     "," before "or" missing.
> 
> Paul Brett wrote:
>     I've switched to shorter sentances, but I don't see anything in the documentation
style guide that expresses a preference between the serial and Oxford comma :)

Serial and Oxford comma are the same: https://en.wikipedia.org/wiki/Serial_comma. But fair
enough, our style guide does not take sides whether to use it or not.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review88352
-----------------------------------------------------------


On June 24, 2015, 2:14 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34835/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 2:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd Mathiske, Ben
Mahler, Dave Lester, Ian Downes, Joerg Schad, Joris Van Remoortere, Michael Park, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-2784
>     https://issues.apache.org/jira/browse/MESOS-2784
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add constexpr to C++11 whitelist
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 
> 
> Diff: https://reviews.apache.org/r/34835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message