mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 35836: Replaced slave's 'available' with 'allocated' in hierarchical allocator.
Date Thu, 25 Jun 2015 01:08:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35836/#review89289
-----------------------------------------------------------

Ship it!


Thanks!


src/master/allocator/mesos/hierarchical.hpp (line 235)
<https://reviews.apache.org/r/35836/#comment141879>

    Maybe a higher level comment above total and allocated to reflect that we can be over-allocated?
    
    ```
    // We track the total and allocated resources on the slave, the
    // available resources are computed as follows:
    //
    //   available = total - allocated
    //
    // Note that it's possible for the slave to be over-allocated!
    // In this case, allocated > total.
    ```
    
    Not sure if we should spell out the cases for over-allocation (currently only when the
revocable total changes..?), since it might become stale in the future (e.g. we allow regular
resources to be over-allocated if operators want to shrink a slave, etc..).



src/master/allocator/mesos/hierarchical.hpp (lines 572 - 573)
<https://reviews.apache.org/r/35836/#comment141891>

    Not yours, but mind moving the ) up?
    
    ```
    LOG(INFO) << "Slave " << slaveId << " (" << slaves[slaveId].hostname
<< ")"
    ```



src/master/allocator/mesos/hierarchical.hpp (line 698)
<https://reviews.apache.org/r/35836/#comment141890>

    Mind moving the " to " down? Will read a bit better:
    
    ```
      << " from " << frameworkAllocation
      << " to " << updatedFrameworkAllocation.get();
    ```



src/master/allocator/mesos/hierarchical.hpp (line 746)
<https://reviews.apache.org/r/35836/#comment141885>

    Hm.. can you keep the available? I think we wanted this log line to help us know what
will be offered next, but without the total we can't tell?
    
    ```
        Resources available = slaves[slaveId].total - slaves[slaveId].allocated;
    
        LOG(INFO) << "Recovered " << resources << " (available: " <<
available << ")"
                  << " on slave " << slaveId << " from framework " <<
frameworkId;
    ```
    
    Or if you wanted to see if it's over-allocated here, maybe we can print both?


- Ben Mahler


On June 24, 2015, 9:53 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35836/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-2919
>     https://issues.apache.org/jira/browse/MESOS-2919
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced slave's 'available' with 'allocated' in hierarchical allocator.
> 
> This is used to fix MESOS-2919. See ticket for details and motivation.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp ef18ff850addfb5ce3500ed28e8ffd801e2d24eb

> 
> Diff: https://reviews.apache.org/r/35836/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message