mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 35353: Smaller fixes on libprocess firewall
Date Wed, 24 Jun 2015 14:26:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35353/#review89158
-----------------------------------------------------------

Ship it!


Lets get this properly rebased and shipped :)


3rdparty/libprocess/include/process/process.hpp (lines 33 - 37)
<https://reviews.apache.org/r/35353/#comment141761>

    s/tested/applied



docs/mesos-frameworks.md (line 29)
<https://reviews.apache.org/r/35353/#comment141765>

    Bad rebase?!



src/Makefile.am (line 892)
<https://reviews.apache.org/r/35353/#comment141766>

    Bad rebase!?



src/slave/containerizer/isolators/network/port_mapping.hpp (lines 68 - 76)
<https://reviews.apache.org/r/35353/#comment141759>

    Rebase?!


- Till Toenshoff


On June 18, 2015, 9:20 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35353/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 9:20 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/firewall.hpp 16ed852d07344e53c6f9d30d4cd7d99e07c6606d

>   3rdparty/libprocess/include/process/process.hpp 6a0b21d67912a40e0ec3220fdb250930be1979b2

>   3rdparty/libprocess/src/process.cpp a67a3afdb30d23eb1b265b04ae662f64e874b6c6 
>   3rdparty/libprocess/src/tests/process_tests.cpp 660af45e7fd45bdf5d43ad9aa54477fd94f87058

>   docs/mesos-frameworks.md 60405b16bfcb4be2fb0424d66d70d38c87c10d2a 
>   src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 
>   src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc 
>   src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf 
>   src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d 
>   src/slave/containerizer/containerizer.cpp c5ffc49899976225e319f122cb5f7556c3b09d46

>   src/slave/containerizer/isolators/network/port_mapping.hpp 7777ee869ce71a68f51d58159c701d3c5d1e502b

>   src/slave/containerizer/isolators/network/port_mapping.cpp 137cdc9b064b02e829af857cff7b9023ee7b7b16

>   src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b 
>   src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d 
> 
> Diff: https://reviews.apache.org/r/35353/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message