mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.
Date Wed, 24 Jun 2015 02:46:29 GMT


> On June 23, 2015, 2:55 p.m., Kapil Arya wrote:
> > src/slave/main.cpp, line 32
> > <https://reviews.apache.org/r/34260/diff/9/?file=990340#file990340line32>
> >
> >     Why do we need this header here? There is no other change in the file.

hah, thanks - forgot to remove that during some of the updates.


> On June 23, 2015, 2:55 p.m., Kapil Arya wrote:
> > src/slave/state.hpp, lines 133-134
> > <https://reviews.apache.org/r/34260/diff/9/?file=990341#file990341line133>
> >
> >     I think this will fit on one line :-).

Aye, fixed.


> On June 23, 2015, 2:55 p.m., Kapil Arya wrote:
> > src/logging/logging.cpp, line 234
> > <https://reviews.apache.org/r/34260/diff/9/?file=990333#file990333line234>
> >
> >     May be replace basename here with 'Path(argv0).basename()'?

True - I also removed the `suffix` instance.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review88985
-----------------------------------------------------------


On June 24, 2015, 2:46 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 2:46 a.m.)
> 
> 
> Review request for mesos and Cody Maloney.
> 
> 
> Bugs: MESOS-1303
>     https://issues.apache.org/jira/browse/MESOS-1303
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos.cpp bb92b68e2945be0a2952f289fb28ca2a89e4c5d8 
>   src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f 
>   src/examples/balloon_framework.cpp 1eb594585867b6c3e206d454900209e8b1b0bb94 
>   src/examples/long_lived_framework.cpp 3f2ebe0011b2f56cbd176c2ddc4c0fcd3dec3326 
>   src/examples/low_level_scheduler_libprocess.cpp fe4eb29b298ecc74680a8c21d190d2540e5e3527

>   src/examples/low_level_scheduler_pthread.cpp 1d285d8aa5e067beac4074bdd6fdf5ba1ba956e8

>   src/examples/persistent_volume_framework.cpp ee2311f500dbcbbd5691638a706f2fd1b8ae910f

>   src/examples/test_framework.cpp 99b981dd1a270dd9da05cdc50ffc365dcb5cdf55 
>   src/files/files.cpp 3cdd38a3c7122bd5e13c8928279d85ab1373a63e 
>   src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7 
>   src/launcher/executor.cpp 9a3a1c3f4952e996bfa12d38627034d18ba9a834 
>   src/linux/cgroups.cpp 6a87ac4019df1c6ec4465adcdfe711812c209ceb 
>   src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9 
>   src/logging/logging.cpp 6b1457503ea1f5c07bacb8b396b8536a8ad97566 
>   src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 21e4284f4a0815be1c6c647a491bd2a7653384da

>   src/slave/containerizer/isolators/cgroups/mem.cpp 9d65bf5b64ce72c1ca9a7a50e65a357e098af63e

>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c

>   src/slave/containerizer/isolators/network/port_mapping.cpp f8018f292b8ca96c1ad5e535d72f18bb4dbfe330

>   src/slave/containerizer/linux_launcher.cpp 7b24db8b9d08d61ecae25facf30823c6eaf5b03a

>   src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5 
>   src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec 
>   src/slave/status_update_manager.cpp 35b943b279c018d846567ec70b374bea83578159 
>   src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8 
>   src/tests/mesos.cpp 2cd2435eba4f911867e7e09338aa28e65b2d1f14 
>   src/zookeeper/group.cpp 33c56da4c83ed6cb272a69df36e6ed2f83583068 
> 
> Diff: https://reviews.apache.org/r/34260/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message