mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 34256: Added Path::dirname() and Path::basename().
Date Tue, 23 Jun 2015 23:16:47 GMT


> On June 23, 2015, 2:37 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, lines 40-52
> > <https://reviews.apache.org/r/34256/diff/7/?file=990279#file990279line40>
> >
> >     It probably applies to the Class itself, but should we also be testing for repeated
middle slashes like "/a//b/c//d/"? Or is it beyond the scope of Path class?

IMHO whatever ::basename / ::dirname produce on such input, we should match -- hence I am
adding your suggested patterns (while also trying them on the standard variants).


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/#review88979
-----------------------------------------------------------


On June 23, 2015, 8:26 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34256/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 8:26 a.m.)
> 
> 
> Review request for mesos and Cody Maloney.
> 
> 
> Bugs: MESOS-1303
>     https://issues.apache.org/jira/browse/MESOS-1303
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Introducing Path::dirname() and Path::basename() as a thread safe replacement of the
respective system functions. Also contains new tests covering corner cases.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 59595c9d0372cb7fc8ec5acbab91ee298b673167

>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 7dd266421377e3f531c15cdf17377141f26c2715

> 
> Diff: https://reviews.apache.org/r/34256/diff/
> 
> 
> Testing
> -------
> 
> make check (including new tests).
> 
> Result comparison to match ::dirname and ::basename on interesting cases.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message