mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 34258: Removed os::dirname and os::basename.
Date Tue, 23 Jun 2015 17:38:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34258/#review89002
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On June 23, 2015, 8:26 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34258/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 8:26 a.m.)
> 
> 
> Review request for mesos and Cody Maloney.
> 
> 
> Bugs: MESOS-1303
>     https://issues.apache.org/jira/browse/MESOS-1303
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> os::dirname and os::basename were not thread safe on OSX. Replacements are path::dirname
and path::basename.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/README.md 377d4fb4cf22e6eafd634c725adb5a50a7629b2b

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1e7aed0b48b8889eb8d042cbd9f907303d2510d3

> 
> Diff: https://reviews.apache.org/r/34258/diff/
> 
> 
> Testing
> -------
> 
> make check on trailing RR.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message