mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path
Date Tue, 23 Jun 2015 05:39:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88924
-----------------------------------------------------------

Ship it!


Thanks for this.

A couple of minor formatting nits.


docs/network-monitoring.md (lines 44 - 48)
<https://reviews.apache.org/r/35763/#comment141542>

    Were you after the `blockquote` effect here, or was this just an artifact of copy &
paste?
    
    I would prefer that you remove the blockquote, and have the code surrounded by the ```
markers.



docs/network-monitoring.md (line 48)
<https://reviews.apache.org/r/35763/#comment141543>

    please format as a markdown URL:
    
    please see [MESOS-1856](https://issues.apache.org/jira/browse/MESOS-1856)
    
    to be consistent with the rest of the document.


- Marco Massenzio


On June 23, 2015, 2:39 a.m., Roger Ignazio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35763/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 2:39 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1856
>     https://issues.apache.org/jira/browse/MESOS-1856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit documents a workaround to MESOS-1856, telling the user that
> they will need to override LIBNL_CFLAGS at build time if libnl3 was
> *not* compiled and installed with `--prefix=/usr`.
> 
> 
> Diffs
> -----
> 
>   docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22 
> 
> Diff: https://reviews.apache.org/r/35763/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roger Ignazio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message