mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.
Date Tue, 23 Jun 2015 00:35:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35567/#review88780
-----------------------------------------------------------

Ship it!



src/slave/flags.cpp (line 28)
<https://reviews.apache.org/r/35567/#comment141369>

    IIUC, then this should be the first include.



src/tests/containerizer.cpp (lines 127 - 128)
<https://reviews.apache.org/r/35567/#comment141472>

    Cant follow this one - are you saying that  `executorEnvironment(..)` should possibly
set environment variables?


- Till Toenshoff


On June 20, 2015, 7 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35567/
> -----------------------------------------------------------
> 
> (Updated June 20, 2015, 7 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-2832
>     https://issues.apache.org/jira/browse/MESOS-2832
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp c5ffc49899976225e319f122cb5f7556c3b09d46

>   src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b 
>   src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 
>   src/tests/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426 
> 
> Diff: https://reviews.apache.org/r/35567/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message