mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <>
Subject Re: Review Request 29507: Added Configurable Slave Ping Timeouts
Date Mon, 22 Jun 2015 10:04:00 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 22, 2015, 3:03 a.m.)

Review request for mesos, Ben Mahler and Niklas Nielsen.


Updated with Niklas and BenM's suggestions. Excluding new unit tests; will post subsequent
review with them.

Bugs: MESOS-2110

Repository: mesos


Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to supplement the DEFAULT_SLAVE_PING_TIMEOUT (15secs)
These can be extended if slaves are expected/allowed to be down for
longer than a minute or two.

Slave will receive master's ping timeout in SlaveRe[re]gisteredMessage.
Beware that this affects recovery from network timeouts as well as
actual slave node/process failover.

Also fixed the log message in recoveredSlavesTimeout() to correctly
reference flags.slave_reregister_timeout instead of the unrelated
ping timeouts.

Diffs (updated)

  docs/ aaf65bf 
  docs/ 355307a 
  src/master/constants.hpp 072d59c 
  src/master/constants.cpp 997b792 
  src/master/flags.hpp 55ed3a9 
  src/master/flags.cpp 4377715 
  src/master/master.cpp 0135c15 
  src/messages/messages.proto 1c8d79e 
  src/slave/constants.hpp 84927e5 
  src/slave/constants.cpp d8d2f98 
  src/slave/slave.hpp f1cf3b8 
  src/slave/slave.cpp 40c0c33 
  src/tests/partition_tests.cpp f7ee3ab 
  src/tests/slave_recovery_tests.cpp c036e9c 
  src/tests/slave_tests.cpp 5030198 



Manually tested slave failover/shutdown with master using different --slave_ping_timeout and
Ran unit tests with shorter non-default values for ping timeouts.
`make check` with new unit tests: ShortPingTimeoutUnreachableMaster and ShortPingTimeoutUnreachableSlave


Adam B

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message