mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.
Date Mon, 22 Jun 2015 04:40:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35714/#review88727
-----------------------------------------------------------

Ship it!


Out of order, but otherwise good. Fix, then ShipIt!


3rdparty/libprocess/include/process/http.hpp (line 473)
<https://reviews.apache.org/r/35714/#comment141299>

    Let's keep these in numerical order, so put this after 404, before 500, please.


- Adam B


On June 21, 2015, 9:16 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35714/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 9:16 a.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Needed in subsequent patch for /reserve master endpoint.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417

> 
> Diff: https://reviews.apache.org/r/35714/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message