mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 35717: Add reservations support to master's state.json
Date Sun, 21 Jun 2015 17:56:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
-----------------------------------------------------------


Thanks for doing this! Looks good to me overall.


src/common/http.cpp (line 88)
<https://reviews.apache.org/r/35717/#comment141259>

    `s/key/role/`



src/master/http.cpp (line 234)
<https://reviews.apache.org/r/35717/#comment141260>

    This is a bug from before, we should use `slave.totalResources` here instead.


- Michael Park


On June 21, 2015, 5:35 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 5:35 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-692
>     https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message