mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 31838: Fixed authentication failure triggered slave crash.
Date Sat, 20 Jun 2015 10:15:10 GMT


> On March 30, 2015, 10:58 a.m., Vinod Kone wrote:
> > I think the bigger problem here is that slave shuts down all the running tasks and
executors if authentication fails. I think that is dangerous. For example if the master is
misconfigured with wrong credentials, this could potentially shut down the whole cluster!
I think the safer thing to do is to EXIT(1) in _authenticate() instead of shutdown().

Excellent idea. Till has implemented this in a separate patch: https://reviews.apache.org/r/35583/diff


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31838/#review78226
-----------------------------------------------------------


On March 8, 2015, 5:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31838/
> -----------------------------------------------------------
> 
> (Updated March 8, 2015, 5:54 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2464
>     https://issues.apache.org/jira/browse/MESOS-2464
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 364d911 
> 
> Diff: https://reviews.apache.org/r/31838/diff/
> 
> 
> Testing
> -------
> 
> make check && functional testing with failed authentication
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message