mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 34362: Include ExecutorInfos in master/state.json
Date Sat, 20 Jun 2015 09:36:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34362/#review88564
-----------------------------------------------------------

Ship it!


Looks great! I'll fix the preexisting typo, and commit this soon.


src/common/http.cpp (line 159)
<https://reviews.apache.org/r/34362/#comment141143>

    Found a typo comment that got copied around: s/in/it/?


- Adam B


On June 7, 2015, 2:29 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34362/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 2:29 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2743
>     https://issues.apache.org/jira/browse/MESOS-2743
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Include ExecutorInfos in master/state.json
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 
>   src/common/http.cpp 2ac7fba7a3aac913540f1b09768777393b79284a 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54 
> 
> Diff: https://reviews.apache.org/r/34362/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> I start 1500 executor in 30 slaves. In executor, it just sleep. And the test result is
> 
> time curl -s -o /dev/null localhost:5050/master/state.json
> 
> real    0m0.651s
> user    0m0.001s
> sys     0m0.004s
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message