mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Review Request 35682: Sped up Allocator::updateSlave() and Allocator::updateAllocation().
Date Sat, 20 Jun 2015 01:08:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35682/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-2891
    https://issues.apache.org/jira/browse/MESOS-2891


Repository: mesos


Description
-------

Allocator::updateSlave() and Allocator::updateAllocation() are so much faster now! See numbers
below.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f 

Diff: https://reviews.apache.org/r/35682/diff/


Testing
-------

make check

[ RUN      ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/0
Added 1000 slaves in 768.327886ms
Updated 1000 slaves in 488.183946ms
[       OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/0 (1435 ms)
[ RUN      ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/1
Added 5000 slaves in 3.796704225secs
Updated 5000 slaves in 2.432450845secs
[       OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/1 (7180 ms)
[ RUN      ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/2
Added 10000 slaves in 7.624720216secs
Updated 10000 slaves in 4.937190687secs
[       OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/2 (14426 ms)
[ RUN      ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/3
Added 20000 slaves in 15.412138292secs
Updated 20000 slaves in 10.148561378secs
[       OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/3 (29457 ms)
[ RUN      ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/4
Added 30000 slaves in 23.182005885secs
Updated 30000 slaves in 15.020974051secs
[       OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/4 (43653 ms)
[ RUN      ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/5
Added 50000 slaves in 38.638591555secs
Updated 50000 slaves in 24.861561733secs
[       OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.UpdateSlave/5 (73836 ms)
[----------] 6 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (169998 ms total)


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message