mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.
Date Fri, 19 Jun 2015 14:31:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/
-----------------------------------------------------------

(Updated June 19, 2015, 2:31 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.


Changes
-------

Added `TaskStatus::REASON_RESOURCES_UNKNOWN`
Added comments around why we need:
```cpp
if (framework->executors.empty() && framework->pending.empty()) {
  removeFramework(framework);
}
```
before we exit `_runTask`.


Bugs: MESOS-2491
    https://issues.apache.org/jira/browse/MESOS-2491


Repository: mesos


Description
-------

No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.


Diffs (updated)
-----

  include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70 
  src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b 

Diff: https://reviews.apache.org/r/35433/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message