mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 35638: Removed const-ref to temporaries from the Slave.
Date Fri, 19 Jun 2015 12:01:03 GMT


> On June 19, 2015, 9:26 a.m., Alexander Rukletsov wrote:
> > src/slave/slave.cpp, line 1280
> > <https://reviews.apache.org/r/35638/diff/1/?file=987726#file987726line1280>
> >
> >     Though currently we guarantee `executorInfo` lifetime is not shorter than `executorId`'s,
I think we agreed to disallow this case as well. Any reason to make an exception here?
> 
> Michael Park wrote:
>     This is the case where we want an **alias** to an object that we know lives somewhere
already. This is captured in the style guide already, here's a snippet:
>     
>     ```
>     // 4: Don't use (since the T that got constructed is a temporary!).
>     const T& t = T("Hello").member();
>     
>     // 4: Preferred alias pattern (see below).
>     const T t("Hello");
>     const T& t_ = t.member();
>     ```

I see. I still think it's more error-prone, while performance benefit is unclear to me. But
it's my personal taste: your approach does not violate the guideline. Dropping the issue.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35638/#review88511
-----------------------------------------------------------


On June 19, 2015, 11:53 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35638/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 11:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2632
>     https://issues.apache.org/jira/browse/MESOS-2632
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b 
> 
> Diff: https://reviews.apache.org/r/35638/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message